Skip to content

chore(ci): add longer timeout and retries for deploying memory#1491

Merged
jariy17 merged 1 commit into
aws:mainfrom
Hweinstock:fix/adjust-timeout
Jun 9, 2026
Merged

chore(ci): add longer timeout and retries for deploying memory#1491
jariy17 merged 1 commit into
aws:mainfrom
Hweinstock:fix/adjust-timeout

Conversation

@Hweinstock

@Hweinstock Hweinstock commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Problem

#1490

Flaky test failure, since it passed on the next run.

 ×  e2e  e2e-tests/strands-bedrock-memory.test.ts > e2e: Strands/Bedrock — create → deploy → invoke > deploys to AWS successfully 600106ms
   → Test timed out in 600000ms.

Solution

  • bump the timeout and retries for memory, using the same mechanism as container.

@github-actions github-actions Bot added the size/xs PR size: XS label Jun 9, 2026
@github-actions github-actions Bot added the agentcore-harness-reviewing AgentCore Harness review in progress label Jun 9, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added the claude-security-reviewing Claude Code /security-review in progress label Jun 9, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Jun 9, 2026
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Package Tarball

aws-agentcore-0.18.0.tgz

How to install

gh release download pr-1491-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.18.0.tgz

@agentcore-cli-automation agentcore-cli-automation left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two small comment-only fixups before merge — the timeout/retry change itself looks correct and matches the existing container pattern.

Comment thread e2e-tests/e2e-helper.ts Outdated
Comment thread e2e-tests/e2e-helper.ts Outdated
@github-actions github-actions Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label Jun 9, 2026
@Hweinstock

Copy link
Copy Markdown
Contributor Author

updated comment to use proper grammar.

@Hweinstock Hweinstock force-pushed the fix/adjust-timeout branch from 216f0de to 02dae53 Compare June 9, 2026 15:56
@github-actions github-actions Bot added size/xs PR size: XS and removed size/xs PR size: XS labels Jun 9, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added the claude-security-reviewing Claude Code /security-review in progress label Jun 9, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Jun 9, 2026
@Hweinstock Hweinstock marked this pull request as ready for review June 9, 2026 16:15
@Hweinstock Hweinstock requested a review from a team June 9, 2026 16:15

@jariy17 jariy17 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work!

@jariy17 jariy17 merged commit 23947ad into aws:main Jun 9, 2026
23 checks passed
@Hweinstock Hweinstock deleted the fix/adjust-timeout branch June 9, 2026 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xs PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants