Skip to content

feat(e2e): enable gemini tests #1503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jariy17 merged 1 commit into from
Jun 10, 2026
+2 −4
Merged

feat(e2e): enable gemini tests #1503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion e2e-tests/googleadk-gemini.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
import { createE2ESuite } from './e2e-helper.js';

createE2ESuite({ framework: 'GoogleADK', modelProvider: 'Gemini', apiKeyEnvVar: 'GEMINI_API_KEY', skipInvoke: true });
createE2ESuite({ framework: 'GoogleADK', modelProvider: 'Gemini', apiKeyEnvVar: 'GEMINI_API_KEY' });
1 change: 0 additions & 1 deletion e2e-tests/harness-gemini.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,4 @@ createHarnessE2ESuite({
modelProvider: 'gemini',
apiKeyEnvVar: 'GEMINI_API_KEY_ARN',

@agentcore-cli-automation agentcore-cli-automation Jun 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

harness-gemini.test.ts reads GEMINI_API_KEY_ARN, but that env var isn't set anywhere in CI — only GEMINI_API_KEY is exposed (e2e-tests.yml line 178, e2e-tests-full.yml line 89, canary.yml line 89). With skipInvoke removed, the harness suite's canRun gate (harness-e2e-helper.ts line 23-24) will now evaluate to false because hasRequiredVar is false, so beforeAll/it blocks all skip — meaning the entire harness Gemini suite (including invoke) silently skips in CI rather than actually running.

In other words, the smoke test you ran locally (with GEMINI_API_KEY_ARN set) doesn't reflect what happens in CI for this file. Some options:

  1. Wire up a GEMINI_API_KEY_ARN secret and export it in the harness step of e2e-tests.yml (around line 173-183), e2e-tests-full.yml, and canary.yml. This is what makes the test actually run.
  2. Change harness-gemini.test.ts to use GEMINI_API_KEY like the other three Gemini tests, if the harness path can accept a raw key (or if the harness e2e helper can be taught to upload the key into a secret as part of setup).
  3. Drop this file from the PR and re-enable harness Gemini in a follow-up once the ARN secret is set up.

The other three test files (googleadk/langgraph/strands) use GEMINI_API_KEY which is wired up correctly, so those will run as intended.

@Hweinstock Hweinstock Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a broader issue where the entire harness tests are skipped. filing an issue and will look into as a follow-up.

@Hweinstock Hweinstock Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1506

skipMemory: true,
skipInvoke: true,
});
1 change: 0 additions & 1 deletion e2e-tests/langgraph-gemini.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,4 @@ createE2ESuite({
framework: 'LangChain_LangGraph',
modelProvider: 'Gemini',
apiKeyEnvVar: 'GEMINI_API_KEY',
skipInvoke: true,
});
2 changes: 1 addition & 1 deletion e2e-tests/strands-gemini.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
import { createE2ESuite } from './e2e-helper.js';

createE2ESuite({ framework: 'Strands', modelProvider: 'Gemini', apiKeyEnvVar: 'GEMINI_API_KEY', skipInvoke: true });
createE2ESuite({ framework: 'Strands', modelProvider: 'Gemini', apiKeyEnvVar: 'GEMINI_API_KEY' });
Loading