chore: bundle local "agent inspector" build#1529
Merged
Merged
Conversation
avi-alpert
changed the title
github-actions
Bot
added
size/s
agentcore-devx-automation
Bot
added
the
claude-security-reviewing
Contributor
Package TarballHow to installgh release download pr-1529-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.19.0.tgz |
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-devx-automation
Bot
removed
the
claude-security-reviewing
agentcore-cli-automation
approved these changes
Jun 11, 2026
agentcore-cli-automation
left a comment
agentcore-cli-automation
left a comment
There was a problem hiding this comment.
Looks good to merge. The change mirrors the existing AGENTCORE_CDK_PATH pattern (env var → sibling → fallback) and writes the locally-built dist-assets/ into dist/agent-inspector/ before npm pack, which is exactly the directory resolveUIDistDir() in src/cli/operations/dev/web-ui/web-server.ts resolves at runtime for a bundled CLI. Ordering (Step 3.5 between CLI build and CLI pack) is correct, and dist/ is already covered by the package's files glob, so the replaced assets ship in the tarball. No tests or telemetry needed for a dev-only bundle script.
github-actions
Bot
removed
the
agentcore-harness-reviewing
avi-alpert
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The bundle script (which generates a tarball for local testing purposes) does not pull in a local copy of agent inspector, like it does with the CDK package.
This PR adds a check for agent-inspector existing in sibling directory, and if it is there, it builds it and pulls in the artifacts into the generated tarball.
Related Issue
Closes #
Documentation PR
Type of Change
Testing
How have you tested the change?
npm run test:unitandnpm run test:integnpm run typechecknpm run lintsrc/assets/, I rannpm run test:update-snapshotsand committed the updated snapshotsChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.