Skip to content

fix(ci): avoid running pr reviewer on closed prs#1536

Merged
Hweinstock merged 1 commit into
aws:mainfrom
Hweinstock:fix/gate-reviewer
Jun 12, 2026
Merged

fix(ci): avoid running pr reviewer on closed prs#1536
Hweinstock merged 1 commit into
aws:mainfrom
Hweinstock:fix/gate-reviewer

Conversation

@Hweinstock

Copy link
Copy Markdown
Contributor

Problem

#1463

Solution

  • add an explicit gate on the workflow to not continue unless the PR is open.

Testing

curl -s https://api.github.com/repos/aws/agentcore-cli/pulls/216 | jq '{state}'
   
  {
    "state": "closed"
  }

@github-actions github-actions Bot added the size/xs PR size: XS label Jun 12, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added the claude-security-reviewing Claude Code /security-review in progress label Jun 12, 2026
@github-actions github-actions Bot added the agentcore-harness-reviewing AgentCore Harness review in progress label Jun 12, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Jun 12, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Package Tarball

aws-agentcore-0.19.0.tgz

How to install

gh release download pr-1536-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.19.0.tgz

@agentcore-cli-automation agentcore-cli-automation left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge. The added gate is a sensible defensive check — even though the workflow only triggers on opened/reopened events, explicitly verifying pull_request.state == 'open' protects against stale/replayed events (which is what issue #1463 describes). The condition correctly skips the check for workflow_dispatch runs.

@github-actions github-actions Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label Jun 12, 2026
@Hweinstock Hweinstock marked this pull request as ready for review June 12, 2026 22:28
@Hweinstock Hweinstock requested a review from a team June 12, 2026 22:28
@Hweinstock Hweinstock merged commit ef1e066 into aws:main Jun 12, 2026
32 checks passed
@Hweinstock Hweinstock deleted the fix/gate-reviewer branch June 12, 2026 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xs PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants