release: nys summit#1547
Conversation
Package TarballHow to installgh release download pr-1547-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.19.0.tgz |
|
Claude Security Review: no high-confidence findings. (run) |
| }, | ||
| "payments": { | ||
| "type": "array", | ||
| "items": { | ||
| "type": "object", | ||
| "properties": { | ||
| "name": { | ||
| "type": "string", | ||
| "minLength": 1, | ||
| "maxLength": 48, | ||
| "pattern": "^[a-zA-Z][a-zA-Z0-9]{0,47}$" | ||
| }, | ||
| "authorizerType": { | ||
| "default": "AWS_IAM", | ||
| "type": "string", | ||
| "enum": ["AWS_IAM", "CUSTOM_JWT"] | ||
| }, |
There was a problem hiding this comment.
not sure why this was deleted but it exists on public main https://github.com/aws/agentcore-cli/blob/main/schemas/agentcore.schema.v1.json
Coverage Report
|
|
Claude Security Review: no high-confidence findings. (run) |
The build-and-test schema-check gate blocks any direct edit to schemas/agentcore.schema.vN.json — the JSON schema is regenerated by the release workflow (release.yml step 'Regenerate JSON schema' runs node scripts/generate-schema.mjs) and committed during release, never by hand on a release PR. Revert this branch's hand-edited schema diff back to main. The release workflow will regenerate it from the source-of-truth Zod schemas in src/schema/ when this PR runs through the actual release flow.
| "filesystemConfigurations": { | ||
| "type": "array", | ||
| "items": { | ||
| "anyOf": [ |
There was a problem hiding this comment.
Why did file system configuration schema get removed?
There was a problem hiding this comment.
I am not sure but I was added it here acf34c4
I made the change so that it is exactly the same as main.
We should not be manually updating this file https://github.com/aws/agentcore-cli/blob/main/schemas/agentcore.schema.v1.json since it is auto-generated with any schema changes during releases. https://github.com/aws/agentcore-cli/blob/main/.github/workflows/release.yml#L124
|
Claude Security Review: no high-confidence findings. (run) |
|
Claude Security Review: no high-confidence findings. (run) |
|
Claude Security Review: the review did not actually analyze this PR (model took 0 turns — the skill likely failed during setup). See the run for details; a later push or re-run is needed for a real review. |
|
E2E Tests already ran in staging environment, and will run again before release. |
public release of features for NYS.