Skip to content

test(e2e): fix shard 4/5 stale paths and missing --wait #1560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hweinstock merged 1 commit into from
Jun 17, 2026
+19 −4
Merged

test(e2e): fix shard 4/5 stale paths and missing --wait #1560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions e2e-tests/archive-lifecycle.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,14 @@ describe.sequential('e2e: archive command lifecycle', () => {
'local .cli/batch-eval-results contains the run record',
() => {
expect(batchEvaluationId, 'batchEvaluationId should have been captured').toBeTruthy();
const filePath = join(projectPath, 'agentcore', '.cli', 'batch-eval-results', `${batchEvaluationId}.json`);
const filePath = join(
projectPath,
'agentcore',
'.cli',
'jobs',
'batch-eval-results',
`${batchEvaluationId}.json`
);
expect(existsSync(filePath), `Expected local record at ${filePath}`).toBe(true);
},
30000
Expand Down Expand Up @@ -196,7 +203,7 @@ describe.sequential('e2e: archive command lifecycle', () => {
'local .cli/recommendations contains the run record',
() => {
expect(recommendationId, 'recommendationId should have been captured').toBeTruthy();
const filePath = join(projectPath, 'agentcore', '.cli', 'recommendations', `${recommendationId}.json`);
const filePath = join(projectPath, 'agentcore', '.cli', 'jobs', 'recommendations', `${recommendationId}.json`);
expect(existsSync(filePath), `Expected local record at ${filePath}`).toBe(true);
},
30000
Expand Down Expand Up @@ -233,7 +240,14 @@ describe.sequential('e2e: archive command lifecycle', () => {
it.skipIf(!canRun)(
'local .cli/batch-eval-results no longer contains the archived record',
() => {
const filePath = join(projectPath, 'agentcore', '.cli', 'batch-eval-results', `${batchEvaluationId}.json`);
const filePath = join(
projectPath,
'agentcore',
'.cli',
'jobs',
'batch-eval-results',
`${batchEvaluationId}.json`
);
expect(existsSync(filePath), `Local record should have been deleted from ${filePath}`).toBe(false);
},
30000
Expand Down Expand Up @@ -297,7 +311,7 @@ describe.sequential('e2e: archive command lifecycle', () => {
it.skipIf(!canRun)(
'local .cli/recommendations no longer contains the archived record',
() => {
const filePath = join(projectPath, 'agentcore', '.cli', 'recommendations', `${recommendationId}.json`);
const filePath = join(projectPath, 'agentcore', '.cli', 'jobs', 'recommendations', `${recommendationId}.json`);
expect(existsSync(filePath), `Local record should have been deleted from ${filePath}`).toBe(false);
},
30000
Expand Down
1 change: 1 addition & 0 deletions e2e-tests/config-bundle-eval-rec.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,6 +491,7 @@ describe.sequential('e2e: config bundles, batch evaluation, and recommendations'
'You are a helpful assistant for testing.',
'--lookback',
'1',
'--wait',
'--json',
]);

Expand Down
Loading