Skip to content

fix: include harness Dockerfiles in deploy hash#1587

Open
jstar0 wants to merge 1 commit into
aws:mainfrom
jstar0:fix/harness-dockerfile-deploy-hash
Open

fix: include harness Dockerfiles in deploy hash#1587
jstar0 wants to merge 1 commit into
aws:mainfrom
jstar0:fix/harness-dockerfile-deploy-hash

Conversation

@jstar0

@jstar0 jstar0 commented Jun 18, 2026

Copy link
Copy Markdown

Summary

Dev-mode deploy skipping currently hashes project and harness config files, but not Dockerfiles referenced by harness specs. That can let canSkipDeploy short-circuit the deploy pipeline after a Dockerfile-only change, before the per-harness deployer hash has a chance to notice the update.

Closes #1380

Changes

This includes the referenced harness Dockerfile content in the project deploy hash, matching the lower-level harness deployer behavior.

Documentation PR

N/A

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other (please describe):

Verification

npm test -- src/cli/operations/deploy/__tests__/change-detection.test.ts
npm test -- src/cli/operations/deploy
npm run typecheck
npm run lint
npm run format:check
npm run build

Note: npm run lint currently reports 34 warnings in pre-existing files outside this change; it reports 0 errors.

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly, or no documentation update is needed
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jstar0 jstar0 requested a review from a team June 18, 2026 18:34
@github-actions github-actions Bot added the size/s PR size: S label Jun 18, 2026
@jstar0 jstar0 changed the title fix: include harness Dockerfiles in deploy change detection fix: include harness Dockerfiles in deploy hash Jun 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/s PR size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change detection skips Dockerfile changes in dev mode

2 participants