test(e2e): use real key formats in payment-validation CDP fixtures#1592
Merged
Conversation
PR #1573 added client-side validation that requires the CoinbaseCDP apiKeySecret to be a base64-encoded Ed25519 key and walletSecret a base64-encoded EC P-256 key. The full E2E suite (which runs on push to main, not on PRs) still seeded those fields with dummy strings, so the add/remove lifecycle tests now tripped the format check instead of exercising their intent. Generate real Ed25519 / P-256 keys for the CDP secret fields. The whitespace-rejection and StripePrivy format tests are unchanged — they assert rejection and still pass.
github-actions
Bot
added
the
agentcore-harness-reviewing
agentcore-devx-automation
Bot
added
the
claude-security-reviewing
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-devx-automation
Bot
removed
the
claude-security-reviewing
Contributor
Package TarballHow to installgh release download pr-1592-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.20.1.tgz |
agentcore-cli-automation
approved these changes
Jun 18, 2026
agentcore-cli-automation
left a comment
agentcore-cli-automation
left a comment
There was a problem hiding this comment.
LGTM — small, focused fix that mirrors the integ-tests update from #1573. Generated key sizes (Ed25519 PKCS#8 DER ≈48 bytes; EC P-256 PKCS#8 DER ≈138 bytes) fall comfortably inside the validator bands (32–64 and 100–200), so the four updated tests will exercise their actual intent (manager-existence check, add/remove lifecycle) rather than tripping the format validator. Whitespace and StripePrivy format tests are correctly left alone. No telemetry needed for a test-fixture change.
github-actions
Bot
removed
the
agentcore-harness-reviewing
Contributor
Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the E2E Tests (Full Suite) failure on
mainintroduced by #1573.#1573 added client-side validation that requires the CoinbaseCDP
apiKeySecretto be a base64-encoded Ed25519 private key andwalletSecreta base64-encoded EC P-256 private key. The full E2E suite runs only on push tomain(it needs AWS secrets unavailable to PRs), so itse2e-tests/payment-validation.test.tsfixtures — which seeded those fields with dummy strings likekey-secret/wallet-secret/b/c— weren't exercised by #1573's PR CI and started failing post-merge: the add/remove lifecycle tests tripped the new format check instead of testing their intent (e.g. "rejects connector on non-existent manager" returned the apiKeySecret format error instead of "not found").This generates real Ed25519 / P-256 keys for the CDP secret fields in the four affected tests. The
integ-tests/equivalent was already updated in #1573; this applies the same fix to thee2e-tests/file.The whitespace-rejection test (asserts "Missing required options" — the missing-check runs before format validation) and the StripePrivy format tests (assert rejection of non-base64 / too-short keys) are unchanged and still pass.
Related Issue
Follow-up to #1573 (which closed #1564). No separate issue.
Closes #
Documentation PR
N/A
Type of Change
Testing
npm run test:unitandnpm run test:integnpm run typechecknpm run lintsrc/assets/, I rannpm run test:update-snapshotsand committed the updated snapshotsNotes:
e2e-tests/payment-validation.test.tschanged.typecheckandprettierpass.Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.