chore: ungate web-search commands (#1558)#1597
Merged
Merged
Conversation
github-actions
Bot
added
size/s
agentcore-devx-automation
Bot
added
the
claude-security-reviewing
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-devx-automation
Bot
removed
the
claude-security-reviewing
Contributor
Package TarballHow to installgh release download pr-1597-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.20.2.tgz |
agentcore-cli-automation
approved these changes
Jun 19, 2026
agentcore-cli-automation
left a comment
agentcore-cli-automation
left a comment
There was a problem hiding this comment.
Reviewed the diff. This is an exact re-apply of #1558 (verified via git diff against the previously-merged commit), and the bug that caused the revert in #1567 has been fixed on main by #1575.
Spot checks all look good:
- Telemetry for
add.web-search/remove.web-searchis already wired insrc/cli/telemetry/schemas/command-run.ts. validate.tsalready acceptsweb-searchungated (line 412), and--exclude-domainsis rejected for non-webSearch types.- Underlying behavior is covered by the
createWebSearchGatewayTargettests insrc/cli/primitives/__tests__/GatewayTargetPrimitive.test.ts. Option,isGatedFeaturesEnabled, andgatePassthroughOptionare still legitimately used by the passthrough code paths after the removal of the localgatehelper.- The change from
addOption(new Option('--exclude-domains …').argParser(excludeDomainsCoercer))to.option('--exclude-domains', desc, excludeDomainsCoercer)is functionally equivalent — both register the same coercer and the only behavioral difference (visibility in--help) is the intended ungating. - Removing the "Coming soon" assertion from
AddScreen.test.tsxis correct since web-search is no longer gated.
LGTM.
github-actions
Bot
removed
the
agentcore-harness-reviewing
Contributor
Coverage Report
|
nborges-aws
changed the title
nborges-aws
changed the title
nborges-aws
changed the title
Hweinstock
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Re-apply of changes in PR #1558. Change was reverted due to a bug that has been confirmed as fixed in PR #1575
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.