feat: ungate AWS skills, managed memory, and read-only harness Version#1620
Open
aidandaly24 wants to merge 1 commit into
Open
feat: ungate AWS skills, managed memory, and read-only harness Version#1620aidandaly24 wants to merge 1 commit into
aidandaly24 wants to merge 1 commit into
Conversation
The NY-Summit AgentCore Harness CFN type is now public in all regions, so the
harness summit-preview features can be ungated. This removes the
ENABLE_GATED_FEATURES gate at the in-scope call sites only — knowledge-base,
gateway passthrough, and config-bundle branch stay gated (they were not part of
this ungating).
Ungated:
- AWS Skills: --aws-skills source on `add skill` and the TUI skill-source picker
(no longer "Coming soon").
- Managed memory: the managed/existing/disabled memory-mode union and the
managed-tuning flags. The legacy "No persistent memory" enabled/disabled TUI
screen is removed; the auto-created `${name}Memory` sibling is gone. "No memory"
(--no-memory / --memory-mode disabled) now writes { mode: 'disabled' }, which
maps to CFN Memory: { Disabled: {} } — a true opt-out instead of silently
getting a service-auto-created memory.
- Harness Version: `status` and the deploy drift note show the config version
unconditionally.
Fixes found while testing (in-scope):
- Reject --no-memory combined with managed-only flags (--memory-strategies /
--memory-event-expiry-days / --memory-encryption-key-arn) instead of silently
dropping them.
- TUI existing-memory retrieval tuning (messages count / topK / relevance) was
silently dropped; the wizard setters now write into the memory union and the
add/create flows share one toMemoryAddOptions() translation helper.
- `deploy --json` no longer emits the managed-memory heads-up notice to stdout
(it corrupted the JSON output); the notice is suppressed under --json and still
recorded in the deploy log.
Tests: ungated and corrected the integ memory-mode coverage (removed the legacy
auto-memory assertions); added unit coverage for memory-mode resolution and the
TUI translation helper; added harness-managed-memory and harness-aws-skills e2e
suites (deploy -> invoke -> memory round-trip / skills-loaded -> teardown),
verified against a real account. 5425 unit tests pass; typecheck + lint clean.
Depends on aws/agentcore-l3-cdk-constructs#289.
github-actions
Bot
added
the
agentcore-harness-reviewing
agentcore-devx-automation
Bot
added
the
claude-security-reviewing
Contributor
Package TarballHow to installgh release download pr-1620-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.20.2.tgz |
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-devx-automation
Bot
removed
the
claude-security-reviewing
github-actions
Bot
removed
the
agentcore-harness-reviewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The NY-Summit
AWS::BedrockAgentCore::HarnessCFN type is now public in all regions, so the harness summit-preview features can be ungated. This removes theENABLE_GATED_FEATURESgate at the in-scope call sites only — knowledge-base, gateway passthrough, and config-bundle branch intentionally stay gated (not part of this ungating; verified still hidden without the flag).Ungated
--aws-skillssource onadd skilland the TUI skill-source picker (no longer "Coming soon").managed/existing/disabledmemory-mode union and the managed-tuning flags. The legacy "No persistent memory" enabled/disabled TUI screen is removed, and the auto-created${name}Memorysibling is gone. "No memory" (--no-memory/--memory-mode disabled) now writes{ mode: 'disabled' }→ CFNMemory: { Disabled: {} }(a true opt-out, instead of silently getting a service-auto-created memory).statusand the deploy drift note show the config version unconditionally.Fixes found while testing (in-scope)
--no-memorycombined with managed-only flags (--memory-strategies/--memory-event-expiry-days/--memory-encryption-key-arn) instead of silently dropping them.toMemoryAddOptions()translation helper.deploy --jsonno longer emits the managed-memory heads-up notice to stdout (it corrupted the JSON output); the notice is suppressed under--jsonand still recorded in the deploy log.Related Issue
Closes #
Documentation PR
Type of Change
Testing
How have you tested the change?
npm run test:unitandnpm run test:integnpm run typechecknpm run lintsrc/assets/, I rannpm run test:update-snapshotsand committed the updated snapshots — N/A (no asset changes)Added/updated: corrected the integ memory-mode coverage (removed legacy auto-memory assertions, ungated the memory-modes describe); added unit coverage for memory-mode resolution (
HarnessPrimitive.add.memory.test.ts) and the TUI translation helper (memory-options.test.ts); addedharness-managed-memoryandharness-aws-skillse2e suites (deploy → invoke → memory round-trip / skills-loaded → teardown), verified against a real account. 5425 unit tests pass; typecheck + lint clean.Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.