chore: add cpp test server v2#10
Merged
Merged
Conversation
kessplas
reviewed
Sep 18, 2025
| @echo " start-python-v3-server : Start only the Python V3 server" | ||
| @echo " start-java-v3-server : Start only the Java V3 server" | ||
| @echo " start-go-v3-server : Start only the Go V3 server" | ||
| @echo " start-cpp-v2-server : Start only the C++ V2 server" |
Contributor
There was a problem hiding this comment.
You'll need to update this Makefile to follow the new convention: #9
Also, these tests don't run in CI, which I presume is because of the failing tests. You can skip them similar to how Go does it.
kessplas
reviewed
Sep 18, 2025
kessplas
reviewed
Sep 18, 2025
mahnushm
reviewed
Sep 19, 2025
mahnushm
reviewed
Sep 19, 2025
mahnushm
reviewed
Sep 19, 2025
mahnushm
reviewed
Sep 19, 2025
mahnushm
reviewed
Sep 19, 2025
mahnushm
approved these changes
Sep 19, 2025
There was a problem hiding this comment.
The code works well overall, but the main things to watch out for are thread safety with client_cache and the manual new/delete handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
6 of the 18 tests fail, because of the whole Encryption Context thing.
I did not update RoundTripTests.java, because of those failures.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.