Skip to content

[Don't merge] chore: add net v2 transition server#110

Closed
rishav-karanjit wants to merge 47 commits into
fireegg-test-serversfrom
netV2TransitionServer
Closed

[Don't merge] chore: add net v2 transition server#110
rishav-karanjit wants to merge 47 commits into
fireegg-test-serversfrom
netV2TransitionServer

Conversation

@rishav-karanjit

@rishav-karanjit rishav-karanjit commented Nov 25, 2025

Copy link
Copy Markdown
Member

Only merge when pen test is done

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@rishav-karanjit rishav-karanjit changed the title chore: add net v2 transition server [Don't merge] chore: add net v2 transition server Nov 25, 2025
@rishav-karanjit rishav-karanjit marked this pull request as ready for review November 25, 2025 23:50
imabhichow
imabhichow previously approved these changes Nov 25, 2025

@imabhichow imabhichow left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rishav-karanjit rishav-karanjit dismissed imabhichow’s stale review November 25, 2025 23:56

Dismissed because I don't want to merge and pen test is going on

@rishav-karanjit

Copy link
Copy Markdown
Member Author

The failure are flaky failure of cpp. Retrying will work. The only thing is it has 38 mins to run test.

This PR is also tested with Ryan's WIP PR which adds a lot of tests. This commit includes Ryan's new test (which is not yet merged): 60f5fc9

@kessplas kessplas closed this May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants