Skip to content

fix(exceptions): properly initialize BotoCoreError subclasses with message formatting#123

Merged
kessplas merged 5 commits into
stagingfrom
tonyknap/feat-exceptions
Jan 27, 2026
Merged

fix(exceptions): properly initialize BotoCoreError subclasses with message formatting#123
kessplas merged 5 commits into
stagingfrom
tonyknap/feat-exceptions

Conversation

@texastony

@texastony texastony commented Jan 15, 2026

Copy link
Copy Markdown

Issue #, if available: #129

Closes #129

Description of changes:
fix(exceptions): properly initialize BotoCoreError subclasses with message formatting

Add BotoCoreError import and implement proper exception initialization:

  • Add fmt class attribute with {msg} placeholder for message formatting
  • Override init to accept message parameter with sensible defaults
  • Add docstrings to init methods
  • Add unit tests for default, custom exception messages, and inherentance.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Comment thread src/s3_encryption/exceptions.py Outdated
Comment thread src/s3_encryption/exceptions.py Outdated
@texastony texastony force-pushed the tonyknap/feat-exceptions branch from 3cfaf8f to 04566db Compare January 24, 2026 20:15
@texastony texastony changed the title Tonyknap/feat exceptions fix(exceptions): properly initialize BotoCoreError subclasses with message formatting Jan 24, 2026
@texastony texastony changed the base branch from tonyknap/fix-readme-uv to staging January 27, 2026 22:01
…ssage formatting

Add BotoCoreError import and implement proper exception initialization:
- Add fmt class attribute with {msg} placeholder for message formatting
- Override __init__ to accept message parameter with sensible defaults
- Add docstrings to __init__ methods
- Add unit tests for default, custom exception messages, and inherentance.

kiro-clie Cost: ~110,565 tokens

Fixes syntax errors and TypeError when raising exceptions with messages.
@texastony texastony force-pushed the tonyknap/feat-exceptions branch from b5eeabb to fa8798c Compare January 27, 2026 22:03
@kessplas kessplas self-requested a review January 27, 2026 22:41
@kessplas kessplas merged commit 894aeb9 into staging Jan 27, 2026
2 checks passed
@kessplas kessplas deleted the tonyknap/feat-exceptions branch January 27, 2026 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants