chore: Refactor test setup utils#15
Merged
Merged
Conversation
kessplas
reviewed
Sep 25, 2025
Comment on lines
+53
to
+57
| public static final Set<String> ENCRYPTION_CONTEXT_ON_DECRYPT_UNSUPPORTED = | ||
| Set.of(GO_V3, PHP_V2, PHP_V3, NET_V2, NET_V3); | ||
|
|
||
| public static final Set<String> ENCRYPTION_CONTEXT_ON_ENCRYPT_UNSUPPORTED = | ||
| Set.of(NET_V2, NET_V3); |
Contributor
There was a problem hiding this comment.
what do you think about possibly making a separate class for "UnsupportedTestConfiguration" or similar?
reason being I think it should as obvious as possible that these library versions don't support these tests, and is worth keeping separate from the rest of the more general utilities
Author
There was a problem hiding this comment.
I will extend this later -- this was just step 1 in a series of refactors I've made for the exhaustive tests
kessplas
reviewed
Sep 25, 2025
Comment on lines
+53
to
+57
| S3ECTestServerClient encClient = TestUtils.testServerClientFor(encLang); | ||
| final String objectKey = "cross-lang-test-key-" + encLang; | ||
| final String input = "simple-test-input"; | ||
| KeyMaterial kmsKeyArn = KeyMaterial.builder() | ||
| .kmsKeyId(KMS_KEY_ARN) | ||
| .kmsKeyId(TestUtils.KMS_KEY_ARN) |
Contributor
There was a problem hiding this comment.
nit: I normally hate star imports, but I believe we can * import TestUtils and not have to prefix everything in this file?
Author
There was a problem hiding this comment.
I'm on board this is a PITA to have all over the place
added 2 commits
September 25, 2025 15:08
kessplas
approved these changes
Sep 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Refactor setup utils into a new file to be re-used by exhaustive tests.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.