refactor: move instruction_file_suffix from S3EncryptionClientConfig to get_object kwarg#159
Merged
texastony merged 1 commit intoMar 27, 2026
Conversation
…to get_object kwarg Move instruction_file_suffix from a client-level config attribute to a per-request keyword argument (InstructionFileSuffix) on get_object(). This allows a single S3EncryptionClient to use different instruction file suffixes per request, matching the spec requirement that custom suffixes be supported on GetObject requests. The suffix is passed through thread-local context to the plugin event handler, following the same pattern as EncryptionContext. Resolves #152.
kessplas
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move instruction_file_suffix from a client-level config attribute to a
per-request keyword argument (InstructionFileSuffix) on get_object().
This allows a single S3EncryptionClient to use different instruction file
suffixes per request, matching the spec requirement that custom suffixes
be supported on GetObject requests.
The suffix is passed through thread-local context to the plugin event
handler, following the same pattern as EncryptionContext.
Resolves #152.