Skip to content

chore: fill in gaps in testing#170

Merged
kessplas merged 13 commits into
stagingfrom
kessplas/test-coverage
Apr 17, 2026
Merged

chore: fill in gaps in testing#170
kessplas merged 13 commits into
stagingfrom
kessplas/test-coverage

Conversation

@kessplas

@kessplas kessplas commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

Issue #, if available: #142, #166, #151

Description of changes:
Fills in gaps in testing. Notably:

  • adds integ tests for key commitment both valid and invalid configurations
  • adds tests for encryption BytesIO objects
  • adds more tests around invalid instruction file cases
  • adds MRK tests
  • splits coverage between unit and integ tests
  • adds custom CMM/keyring tests
  • adds tests for error propagation from S3/KMS

There are exactly two functional changes in this PR:

  • add a getattr method which proxies requests to the wrapped S3 client. this lets customers call "normal" S3EC operations on the S3EC instance
  • add validation against invalid (non-US-ASCII) characters in encryption context.

You can view the test plan / its evaluation in this dummy PR: #171

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kessplas kessplas changed the base branch from main to staging April 2, 2026 20:10
@kessplas kessplas marked this pull request as ready for review April 7, 2026 22:59
Comment thread src/s3_encryption/__init__.py Outdated
Comment thread test/integration/test_i_mrk_cross_region.py
Comment thread test/integration/test_i_s3_encryption.py
@kessplas kessplas merged commit 099ab77 into staging Apr 17, 2026
5 checks passed
@kessplas kessplas deleted the kessplas/test-coverage branch April 17, 2026 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants