chore(perf): add performance testing#173
Merged
Merged
Conversation
texastony
approved these changes
Apr 17, 2026
|
|
||
| jobs: | ||
| python-perf: | ||
| runs-on: macos-14-large |
There was a problem hiding this comment.
Why run the performance test on macos-14-large?
Ubuntu is cheaper and faster to provision.
| resp["Body"].read() | ||
| return time.perf_counter() - t0 | ||
|
|
||
| def run_local(): |
There was a problem hiding this comment.
Issue: Why call this local?
What is this testing?
It feels like it is testing all the ingredients of the S3EC together without testing the S3EC. Which makes sense, as it can be used to determine the local cost... OH... it determines the non-network latency... or the local latency... got it.
…python into kessplas/perf-test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes: Adds a rudimentary performance test.
There is limited utility in this test as it is subject to heavy noise from network conditions and S3's backend performance. As such there is no reliable baseline that could be automated against (e.g. failing CI when performance regresses). It is included for completeness.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.