feat: delete_object and delete_objects#175
Merged
Merged
Conversation
Implement delete_object per the spec requirement that DeleteObject MUST delete both the given object key and its associated instruction file. Accepts an optional InstructionFileSuffix kwarg (default ".instruction") mirroring get_object's per-request suffix pattern.
Implement DeleteObjects on S3EncryptionClient per spec requirements: - DeleteObjects MUST delete each of the given objects - DeleteObjects MUST delete each of the corresponding instruction files using the default instruction file suffix Uses two separate delete_objects calls (objects, then instruction files) to preserve the S3 1,000-key limit for callers and keep the response clean. Follows the same pattern as the existing delete_object method.
texastony
changed the title
kessplas
requested changes
Apr 17, 2026
kessplas
left a comment
kessplas
left a comment
Contributor
There was a problem hiding this comment.
In addition to the existing unit tests we should also have integration tests for delete_object(s).
kessplas
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement delete_object per the spec requirement that DeleteObject MUST
delete both the given object key and its associated instruction file.
Accepts an optional InstructionFileSuffix kwarg (default ".instruction")
mirroring get_object's per-request suffix pattern.
Implement DeleteObjects on S3EncryptionClient per spec requirements:
using the default instruction file suffix
Uses two separate delete_objects calls (objects, then instruction files)
to preserve the S3 1,000-key limit for callers and keep the response
clean. Follows the same pattern as the existing delete_object method.
Closes #158