chore: guard against None dict, always default to {}#177
Merged
Conversation
sharmabikram
reviewed
May 1, 2026
| if isinstance(enc_mats_request, dict): | ||
| materials = EncryptionMaterials( | ||
| encryption_context=enc_mats_request.get("encryption_context", {}) | ||
| encryption_context=enc_mats_request.get("encryption_context", {}) or {} |
There was a problem hiding this comment.
Since this is used in multiple places, is it worth having a utility method?
| "encryption_context_from_request", {} | ||
| ), | ||
| ) | ||
| or {}, |
There was a problem hiding this comment.
Readability: In my view, this separate line may cause confusion while reading.
Contributor
Author
There was a problem hiding this comment.
Formatting is enforced by ruff. Making this a utility function makes it a moot point anyway.
rishav-karanjit
approved these changes
May 6, 2026
rishav-karanjit
left a comment
rishav-karanjit
left a comment
Member
There was a problem hiding this comment.
LGTM.
I agree with Bikram's comments about having a Utlity method to get the EC and it should be totally worth it. I will let Kess decide if its worth it and on priority of doing it.
sharmabikram
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: n/a
Description of changes:
The
get()method considers the presence ofNoneas a valid key and won't default to{}.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.