Skip to content

chore(cdk): add ToolsDevelopment to assume test role #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
imabhichow merged 1 commit into from
Sep 25, 2025
Merged

chore(cdk): add ToolsDevelopment to assume test role #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion cdk/lib/cdk-stack.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ import {
PolicyDocument,
PolicyStatement,
FederatedPrincipal,
ArnPrincipal,
CompositePrincipal,
ManagedPolicy,
} from "aws-cdk-lib/aws-iam";
import {
Expand Down Expand Up @@ -170,11 +172,21 @@ export class S3ECPythonGithub extends cdk.Stack {
},
"sts:AssumeRoleWithWebIdentity"
)

// ToolsDevelopment role principal
const ToolsDevelopmentPrincipal = new ArnPrincipal("arn:aws:iam::" + this.account + ":role/ToolsDevelopment")

// Composite principal to allow both GitHub Actions and ToolsDevelopment to assume the role
const CompositePrincipalForRole = new CompositePrincipal(
GithubActionsPrincipal,
ToolsDevelopmentPrincipal
)

const S3ECGithubTestRole = new Role(
this,
"s3-github-test-role",
{
assumedBy: GithubActionsPrincipal,
assumedBy: CompositePrincipalForRole,
roleName: "S3EC-Python-Github-test-role",
description: " Grant GitHub S3 put and get and KMS encrypt, decrypt, and generate access for testing",
path: "/",
Expand Down
Loading