chore(test): fix flaky tests, add more platforms#183
Merged
Conversation
…python into kessplas/fix-flaky-cbc-test
…python into kessplas/fix-flaky-cbc-test
Comment on lines
51
to
55
| - name: Configure AWS credentials | ||
| uses: aws-actions/configure-aws-credentials@v6 | ||
| with: | ||
| role-to-assume: arn:aws:iam::370957321024:role/S3EC-Python-Github-test-role | ||
| aws-region: us-west-2 |
Member
There was a problem hiding this comment.
This is not in the diff but I wanted to call out. windows cannot handle special characters in AWS secrets. Because of this an option special-characters-workaround exists. Read more in my PR: aws/aws-cryptographic-material-providers-library#1874
Member
There was a problem hiding this comment.
Without special-characters-workaround it will cause flaky CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: n/a
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.