chore: add test for RSA decryption validation for v1 object#194
Merged
Conversation
This test class verifies the decryption of RSA-encrypted objects using legacy wrapping. It includes setup for encryption and parameterized tests for various runtime and policy combinations.
Refactor rsaRuntimeAndPolicyMatrix to remove unused configurations.
kessplas
reviewed
Jun 11, 2026
kessplas
reviewed
Jun 11, 2026
kessplas
reviewed
Jun 11, 2026
|
|
||
| @ParameterizedTest(name = "Encrypt: Java-V1-RSA, Decrypt: {0} / {1}") | ||
| @MethodSource("rsaRuntimeAndPolicyMatrix") | ||
| void canDecryptV1RsaObjectWithLegacyEnabled(LanguageServerTarget language, String configName, |
Contributor
There was a problem hiding this comment.
suggestion: also include a negative test when enableLegacyWrappingAlgorithms(false)
Member
Author
There was a problem hiding this comment.
Let's do that in private repo
Co-authored-by: Kess Plasmeier <76071473+kessplas@users.noreply.github.com>
Co-authored-by: Kess Plasmeier <76071473+kessplas@users.noreply.github.com>
kessplas
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Add test that verifies the decryption of RSA-encrypted v1 objects succeeds with newer clients.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.