Adding duvet for a specific Ruby test server#26
Merged
Conversation
lucasmcdonald3
previously approved these changes
Sep 29, 2025
kessplas
reviewed
Sep 29, 2025
|
|
||
| # Include required specifications here | ||
| [[specification]] | ||
| source = "../specification/s3-encryption/data-format/content-metadata.md" |
Contributor
There was a problem hiding this comment.
nit: maybe just use ../specification/s3-encryption/data-format/*.md ?
Author
There was a problem hiding this comment.
Does not work :(
% make duvet
duvet report
Extracting requirements
× ../specification/s3-encryption/data-format/*.md
╰─▶ No such file or directory (os error 2)
kessplas
reviewed
Sep 29, 2025
| @@ -0,0 +1,217 @@ | |||
| target = "../specification/s3-encryption/data-format/content-metadata.md#content-metadata-mapkeys" | |||
Contributor
There was a problem hiding this comment.
i don't think we want to check this in?
Author
There was a problem hiding this comment.
The way Duvet works, is that file is so that we can configure extra requirements. I can remove it, but we commit these files everywhere else
kessplas
reviewed
Sep 29, 2025
| duvet: | ||
| duvet report | ||
|
|
||
| view-report-mac: |
Contributor
There was a problem hiding this comment.
suggestion: also upload the report using the upload-artifacts action, see #20 for an example
Author
There was a problem hiding this comment.
You are suggesting also adding it to CI? Then we also need to install duvet and all that.
lucasmcdonald3
approved these changes
Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This sets up
duvetto run in theruby-v2-serverdirectory.The Makefile in that directory has targets
duvetandview-report-mac.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.