Trying to get KC and tests working for Ruby#34
Merged
Conversation
lucasmcdonald3
left a comment
lucasmcdonald3
left a comment
There was a problem hiding this comment.
Why bump Ruby V2 submodule? Is that the "current" or the "transition" S3EC? Or both?
|
|
||
| @readonly | ||
| @http(method: "GET", uri: "/object/{bucket}/{key}") | ||
| operation ReEncrypt { |
There was a problem hiding this comment.
Do we know these are the input/output shapes we want?
I just copy-pasted the PutObject API without changes. I wouldn't be surprised if we don't want ReEncrypt to return the body, for example
Author
There was a problem hiding this comment.
I do not. I just copied it.
My goal is to get the tests for commit_key algos into the testing.
lucasmcdonald3
approved these changes
Oct 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.