Seebees/more complete tests#36
Merged
Merged
Conversation
lucasmcdonald3
previously approved these changes
Oct 14, 2025
There was a problem hiding this comment.
Pull Request Overview
Adds comprehensive CBC and GCM test coverage and introduces an EncryptionAlgorithm model to support validating encryption modes. Also makes Ruby test servers port-configurable via environment variables and adjusts client configuration for legacy modes.
- Add KC-GCM, GCM, and CBC decryption integration tests with shared helpers for encrypt/decrypt flows.
- Update Ruby v2 client manager to set security_profile based on legacy flags; make Ruby servers read port from ENV.
- Extend Smithy model with EncryptionAlgorithm enum and config field.
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| test-server/ruby-v3-server/local-ruby-sdk | Submodule updated to newer commit. |
| test-server/ruby-v3-server/lib/client_manager.rb | Removes unused legacy wrapping flag handling (commented code cleaned). |
| test-server/ruby-v3-server/app.rb | Server now reads port from ENV with fallback. |
| test-server/ruby-v3-server/Makefile | Exports PORT to app; writes PID to PID_FILE. |
| test-server/ruby-v2-server/local-ruby-sdk | Submodule updated to newer commit. |
| test-server/ruby-v2-server/lib/client_manager.rb | Computes security_profile from legacy flags via tap block. |
| test-server/ruby-v2-server/app.rb | Server now reads port from ENV with 8098 fallback. |
| test-server/ruby-v2-server/Makefile | Defines PORT=8098, passes to app, standardizes PID handling. |
| test-server/model/client.smithy | Adds EncryptionAlgorithm enum and S3ECConfig.encryptionAlgorithm; adjusts CommitmentPolicy formatting. |
| test-server/java-tests/src/it/java/software/amazon/encryption/s3/TestUtils.java | Adds helpers for encryption/decryption and algorithm detection. Updates server targets. |
| test-server/java-tests/src/it/java/software/amazon/encryption/s3/RoundTripTests.java | Expands assertions to include RUBY_V2_TRANSITION. |
| test-server/java-tests/src/it/java/software/amazon/encryption/s3/KC_GCMTests.java | New KC-GCM test suite. |
| test-server/java-tests/src/it/java/software/amazon/encryption/s3/GCMTests.java | New GCM test suite. |
| test-server/java-tests/src/it/java/software/amazon/encryption/s3/CBCDecryptTests.java | New CBC decryption test suite using V1 client to produce CBC objects. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
lucasmcdonald3
previously approved these changes
Oct 15, 2025
…s3/CBCDecryptTests.java Co-authored-by: Lucas McDonald <lucasmcdonald3@gmail.com>
lucasmcdonald3
previously approved these changes
Oct 16, 2025
lucasmcdonald3
approved these changes
Oct 23, 2025
ajewellamz
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding CBC and GCM tests.
Starting to organize all the complete test cases for commitment policy.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.