Skip to content

Seebees/more complete tests#36

Merged
seebees merged 18 commits into
fireegg-test-serversfrom
seebees/more-complete-tests
Oct 23, 2025
Merged

Seebees/more complete tests#36
seebees merged 18 commits into
fireegg-test-serversfrom
seebees/more-complete-tests

Conversation

@seebees

@seebees seebees commented Oct 14, 2025

Copy link
Copy Markdown

Adding CBC and GCM tests.

Starting to organize all the complete test cases for commitment policy.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

lucasmcdonald3
lucasmcdonald3 previously approved these changes Oct 14, 2025

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds comprehensive CBC and GCM test coverage and introduces an EncryptionAlgorithm model to support validating encryption modes. Also makes Ruby test servers port-configurable via environment variables and adjusts client configuration for legacy modes.

  • Add KC-GCM, GCM, and CBC decryption integration tests with shared helpers for encrypt/decrypt flows.
  • Update Ruby v2 client manager to set security_profile based on legacy flags; make Ruby servers read port from ENV.
  • Extend Smithy model with EncryptionAlgorithm enum and config field.

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
test-server/ruby-v3-server/local-ruby-sdk Submodule updated to newer commit.
test-server/ruby-v3-server/lib/client_manager.rb Removes unused legacy wrapping flag handling (commented code cleaned).
test-server/ruby-v3-server/app.rb Server now reads port from ENV with fallback.
test-server/ruby-v3-server/Makefile Exports PORT to app; writes PID to PID_FILE.
test-server/ruby-v2-server/local-ruby-sdk Submodule updated to newer commit.
test-server/ruby-v2-server/lib/client_manager.rb Computes security_profile from legacy flags via tap block.
test-server/ruby-v2-server/app.rb Server now reads port from ENV with 8098 fallback.
test-server/ruby-v2-server/Makefile Defines PORT=8098, passes to app, standardizes PID handling.
test-server/model/client.smithy Adds EncryptionAlgorithm enum and S3ECConfig.encryptionAlgorithm; adjusts CommitmentPolicy formatting.
test-server/java-tests/src/it/java/software/amazon/encryption/s3/TestUtils.java Adds helpers for encryption/decryption and algorithm detection. Updates server targets.
test-server/java-tests/src/it/java/software/amazon/encryption/s3/RoundTripTests.java Expands assertions to include RUBY_V2_TRANSITION.
test-server/java-tests/src/it/java/software/amazon/encryption/s3/KC_GCMTests.java New KC-GCM test suite.
test-server/java-tests/src/it/java/software/amazon/encryption/s3/GCMTests.java New GCM test suite.
test-server/java-tests/src/it/java/software/amazon/encryption/s3/CBCDecryptTests.java New CBC decryption test suite using V1 client to produce CBC objects.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread test-server/ruby-v3-server/app.rb
Comment thread test-server/ruby-v3-server/Makefile
Comment thread test-server/ruby-v2-server/lib/client_manager.rb
lucasmcdonald3
lucasmcdonald3 previously approved these changes Oct 15, 2025
Comment thread test-server/ruby-v3-server/Makefile
Comment thread test-server/ruby-v2-server/lib/client_manager.rb
…s3/CBCDecryptTests.java

Co-authored-by: Lucas McDonald <lucasmcdonald3@gmail.com>
lucasmcdonald3
lucasmcdonald3 previously approved these changes Oct 16, 2025
@seebees seebees merged commit 4ad0e87 into fireegg-test-servers Oct 23, 2025
3 checks passed
@seebees seebees deleted the seebees/more-complete-tests branch October 23, 2025 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants