chore: s3ec-java v4 improved tests server#42
Merged
imabhichow merged 29 commits intoNov 10, 2025
Conversation
imabhichow
changed the title
imabhichow
force-pushed
the
imabhichow/java-v4-extended-tests
branch
from
8d108f3 to
99ac2d4
Compare
Base automatically changed from
seebees/more-complete-tests
to
fireegg-test-servers
October 23, 2025 23:46
imabhichow
force-pushed
the
imabhichow/java-v4-extended-tests
branch
from
040de80 to
b47d846
Compare
imabhichow
force-pushed
the
imabhichow/java-v4-extended-tests
branch
from
c36c215 to
ddfdb9b
Compare
This reverts commit 8c6db9e.
imabhichow
changed the title
imabhichow
force-pushed
the
imabhichow/java-v4-extended-tests
branch
from
24a5333 to
d0457ad
Compare
| servers.put(CPP_V2_TRANSITION, new LanguageServerTarget(CPP_V2_TRANSITION, "8097")); | ||
| servers.put(RUBY_V2_TRANSITION, new LanguageServerTarget(RUBY_V2_TRANSITION, "8098")); | ||
| servers.put(PHP_V2_TRANSITION, new LanguageServerTarget(PHP_V2_TRANSITION, "8099")); | ||
| servers.put(JAVA_V4, new LanguageServerTarget(JAVA_V4, "8090")); |
Member
There was a problem hiding this comment.
Note: I changed this to 8088 (in my PR: https://github.com/aws/amazon-s3-encryption-client-python/pull/54/files#diff-08db38a86ab4a01be997d0d169c28c907f90a73d136bb34355afc22502aa3670R149) because the quip doc says 8088 is for Java.
| // servers.put(JAVA_V3_TRANSITION, new LanguageServerTarget(JAVA_V3_TRANSITION, "8094")); | ||
| // servers.put(GO_V3_TRANSITION, new LanguageServerTarget(GO_V3_TRANSITION, "8095")); | ||
| // servers.put(NET_V2_TRANSITION, new LanguageServerTarget(NET_V2_TRANSITION, "8096")); | ||
| servers.put(CPP_V2_TRANSITION, new LanguageServerTarget(CPP_V2_TRANSITION, "8097")); |
Member
There was a problem hiding this comment.
Is this an intended change?
Author
There was a problem hiding this comment.
I think CPP test server changed a lot since my last merge.
…ichow/java-v4-extended-tests
Comment on lines
6
to
+14
| # Include required specifications here | ||
| [[specification]] | ||
| source = "../specification/s3-encryption/data-format/content-metadata.md" | ||
| source = "specification/s3-encryption/data-format/content-metadata.md" | ||
| [[specification]] | ||
| source = "../specification/s3-encryption/data-format/metadata-strategy.md" | ||
| source = "specification/s3-encryption/data-format/metadata-strategy.md" | ||
| [[specification]] | ||
| source = "../specification/s3-encryption/encryption.md" | ||
| source = "specification/s3-encryption/encryption.md" | ||
| [[specification]] | ||
| source = "../specification/s3-encryption/key-derivation.md" | ||
| source = "specification/s3-encryption/key-derivation.md" |
Member
There was a problem hiding this comment.
Suggested change
| # Include required specifications here | |
| [[specification]] | |
| source = "../specification/s3-encryption/data-format/content-metadata.md" | |
| source = "specification/s3-encryption/data-format/content-metadata.md" | |
| [[specification]] | |
| source = "../specification/s3-encryption/data-format/metadata-strategy.md" | |
| source = "specification/s3-encryption/data-format/metadata-strategy.md" | |
| [[specification]] | |
| source = "../specification/s3-encryption/encryption.md" | |
| source = "specification/s3-encryption/encryption.md" | |
| [[specification]] | |
| source = "../specification/s3-encryption/key-derivation.md" | |
| source = "specification/s3-encryption/key-derivation.md" | |
| # Include required specifications here | |
| [[specification]] | |
| source = "specification/s3-encryption/client.md" | |
| [[specification]] | |
| source = "specification/s3-encryption/decryption.md" | |
| [[specification]] | |
| source = "specification/s3-encryption/encryption.md" | |
| [[specification]] | |
| source = "specification/s3-encryption/key-commitment.md" | |
| [[specification]] | |
| source = "specification/s3-encryption/key-derivation.md" | |
| [[specification]] | |
| source = "specification/s3-encryption/data-format/content-metadata.md" | |
| [[specification]] | |
| source = "specification/s3-encryption/data-format/metadata-strategy.md" |
Member
There was a problem hiding this comment.
Ignore this. This is current Java V3 server for which I don't care about duvet
Comment on lines
6
to
+14
| # Include required specifications here | ||
| [[specification]] | ||
| source = "../specification/s3-encryption/data-format/content-metadata.md" | ||
| source = "specification/s3-encryption/data-format/content-metadata.md" | ||
| [[specification]] | ||
| source = "../specification/s3-encryption/data-format/metadata-strategy.md" | ||
| source = "specification/s3-encryption/data-format/metadata-strategy.md" | ||
| [[specification]] | ||
| source = "../specification/s3-encryption/encryption.md" | ||
| source = "specification/s3-encryption/encryption.md" | ||
| [[specification]] | ||
| source = "../specification/s3-encryption/key-derivation.md" | ||
| source = "specification/s3-encryption/key-derivation.md" |
Member
There was a problem hiding this comment.
Ignore this. This is current Java V3 server for which I don't care about duvet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.