chore: Bump Go V4 server to spec-complete commit#43
Merged
Conversation
…odules/amazon-s3-encryption-client-go'
…ient-python into go-v4-server
lucasmcdonald3
changed the title
…ient-python into go-v4-server
…ient-python into go-v4-server
seebees
previously approved these changes
Oct 27, 2025
| .keyMaterial(kmsKeyArn) | ||
| // .commitmentPolicy(CommitmentPolicy.FORBID_ENCRYPT_ALLOW_DECRYPT) | ||
| .enableLegacyUnauthenticatedModes(true) | ||
| .enableLegacyWrappingAlgorithms(true) |
There was a problem hiding this comment.
This is not required per se. Because CBC is an unauthenticated content mode, now a wrapping mode.
There was a problem hiding this comment.
Ruby does everything if either of these is true, because it only have v2_and_legacy
Co-authored-by: seebees <ryanemer@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Duvet CI is failing because I updated the spec commit to a commit with different text.
The Ruby implementations don't conform to the new spec's text.
I don't have permissions to access the Ruby repos to update their Duvet annotations to use the new text.
I chatted with Ryan about what to do here.
We decided that we should simply ignore Duvet failures and merge in.
We don't want to update the CI to report green when Duvet fails, since we don't want to forget that Duvet is failing.
But we should not block merges on Duvet failures (until we're close to being done).
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.