chore: add .net transition servers#48
Merged
Merged
Conversation
This reverts commit 3ab7193.
rishav-karanjit
changed the title
…n-s3-encryption-client-python into rishav/add-net-servers
This reverts commit 73b9d27.
This reverts commit 1ada2e9.
texastony
approved these changes
Oct 29, 2025
texastony
left a comment
texastony
left a comment
There was a problem hiding this comment.
Looks good to me.
Going to see if I can check the CI logs.
texastony
suggested changes
Oct 29, 2025
texastony
left a comment
texastony
left a comment
There was a problem hiding this comment.
Blocking: While the code looks correct, I cannot decipher what logs, if any, are emitted by either the Java Test runner or the S3EC .NET server, and therefore cannot determine IF this PR is reading objects from other implementations.
It is clear that at least Go V4 and Go V3 are reading the "NET-V3-Transition" messages, but everything else is gray.
texastony
previously approved these changes
Oct 29, 2025
texastony
left a comment
texastony
left a comment
There was a problem hiding this comment.
Removing my blocking comment.
I did not know that the CI generated a test report that included all of the round trip encrypt/decrypts.
…n-s3-encryption-client-python into rishav/add-net-servers
imabhichow
approved these changes
Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.