chore: add instruction file support to TestServer#56
Merged
Conversation
…ption-client-python into kessplas/inst-file
…ption-client-python into kessplas/inst-file
seebees
approved these changes
Nov 6, 2025
| /// This also requires a way to create non-encrypted clients which we don't have yet. | ||
| clientId: String, | ||
| enableInstructionFilePutObject: Boolean = false, | ||
| disableInstructionFile: Boolean = false |
There was a problem hiding this comment.
are we adding custom suffix?
Otherwise, how do I decrypt something that was ReEncrypted?
(Also, ruby supports writing with a custom suffix)
Contributor
Author
There was a problem hiding this comment.
this would need to be done as a parameter to the get object request,
and is out of scope for this PR,
though we should do it at some point
…ption-client-python into kessplas/inst-file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.