Skip to content

cpp duvet coverage #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ajewellamz merged 4 commits into from
Nov 5, 2025
+79 −2
Merged

cpp duvet coverage #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8a712ef
duvet
ajewellamz Nov 5, 2025
3f7c6ab
m
ajewellamz Nov 5, 2025
37ffd26
m
ajewellamz Nov 5, 2025
a5c35db
m
ajewellamz Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,20 @@ jobs:
uses: ./.github/workflows/lint.yml

run-tests:
permissions:
id-token: write
contents: read
name: Run Tests
uses: ./.github/workflows/test.yml
with:
python-version: ${{ inputs.python-version || '3.11' }}
secrets: inherit

run-duvet:
permissions:
id-token: write
contents: read
pages: write
name: Run Duvet
uses: ./.github/workflows/duvet.yml
secrets: inherit
12 changes: 11 additions & 1 deletion test-server/cpp-v2-transition-server/.duvet/config.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,17 @@ pattern = "aws-sdk-cpp/src/aws-cpp-sdk-s3-encryption/**/*.cpp"
[[source]]
pattern = "aws-sdk-cpp/src/aws-cpp-sdk-s3-encryption/**/*.h"

# Include required specifications here
[[source]]
pattern = "aws-sdk-cpp/src/aws-cpp-sdk-core/include/aws/core/utils/crypto/*.h"

[[source]]
pattern = "aws-sdk-cpp/src/aws-cpp-sdk-core/include/aws/core/utils/crypto/*.cpp"

[[source]]
pattern = "compliance.txt"

[[specification]]
source = "../specification/s3-encryption/client.md"
[[specification]]
source = "../specification/s3-encryption/data-format/content-metadata.md"
[[specification]]
Expand Down
25 changes: 25 additions & 0 deletions test-server/cpp-v2-transition-server/compliance.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
We're not doing double encoding yet

//= ../specification/s3-encryption/data-format/metadata-strategy.md#object-metadata
//= type=exception
//# The S3EC SHOULD support decoding the S3 Server's "double encoding".



Yes, this is how we do prefixes.

//= ../specification/s3-encryption/data-format/content-metadata.md#content-metadata-mapkeys
//= type=exception
//# The "x-amz-meta-" prefix is automatically added by the S3 server and MUST NOT be included in implementation code.

//= ../specification/s3-encryption/data-format/content-metadata.md#content-metadata-mapkeys
//= type=exception
//# The "x-amz-" prefix denotes that the metadata is owned by an Amazon product and MUST be prepended to all S3EC metadata mapkeys.



We do not support a custom Instruction File suffix under any circumstances.

//= ../specification/s3-encryption/data-format/metadata-strategy.md#instruction-file
//= type=exception
//# The S3EC MUST NOT support providing a custom Instruction File suffix on ordinary writes; custom suffixes MUST only be used during re-encryption.
12 changes: 11 additions & 1 deletion test-server/cpp-v3-server/.duvet/config.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,17 @@ pattern = "aws-sdk-cpp/src/aws-cpp-sdk-s3-encryption/**/*.cpp"
[[source]]
pattern = "aws-sdk-cpp/src/aws-cpp-sdk-s3-encryption/**/*.h"

# Include required specifications here
[[source]]
pattern = "aws-sdk-cpp/src/aws-cpp-sdk-core/include/aws/core/utils/crypto/*.h"

[[source]]
pattern = "aws-sdk-cpp/src/aws-cpp-sdk-core/include/aws/core/utils/crypto/*.cpp"

[[source]]
pattern = "compliance.txt"

[[specification]]
source = "../specification/s3-encryption/client.md"
[[specification]]
source = "../specification/s3-encryption/data-format/content-metadata.md"
[[specification]]
Expand Down
25 changes: 25 additions & 0 deletions test-server/cpp-v3-server/compliance.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
We're not doing double encoding yet

//= ../specification/s3-encryption/data-format/metadata-strategy.md#object-metadata
//= type=exception
//# The S3EC SHOULD support decoding the S3 Server's "double encoding".



Yes, this is how we do prefixes.

//= ../specification/s3-encryption/data-format/content-metadata.md#content-metadata-mapkeys
//= type=exception
//# The "x-amz-meta-" prefix is automatically added by the S3 server and MUST NOT be included in implementation code.

//= ../specification/s3-encryption/data-format/content-metadata.md#content-metadata-mapkeys
//= type=exception
//# The "x-amz-" prefix denotes that the metadata is owned by an Amazon product and MUST be prepended to all S3EC metadata mapkeys.



We do not support a custom Instruction File suffix under any circumstances.

//= ../specification/s3-encryption/data-format/metadata-strategy.md#instruction-file
//= type=exception
//# The S3EC MUST NOT support providing a custom Instruction File suffix on ordinary writes; custom suffixes MUST only be used during re-encryption.
Loading