Go V3 transition server, duvet'ed#60
Merged
Merged
Conversation
lucasmcdonald3
changed the title
…ryption-client-python into go-v3-transition-duvet
…ryption-client-python into go-v3-transition-duvet
…ryption-client-python into go-v3-transition-duvet
lucasmcdonald3
changed the title
ShubhamChaturvedi7
previously approved these changes
Nov 10, 2025
ShubhamChaturvedi7
left a comment
ShubhamChaturvedi7
left a comment
Contributor
There was a problem hiding this comment.
Minor / Clarification below, lgtm.
Comment on lines
+152
to
+159
| var commitmentPolicy commitment.CommitmentPolicy | ||
| switch input.Config.CommitmentPolicy { | ||
| case "REQUIRE_ENCRYPT_REQUIRE_DECRYPT": | ||
| commitmentPolicy = commitment.REQUIRE_ENCRYPT_REQUIRE_DECRYPT | ||
| case "REQUIRE_ENCRYPT_ALLOW_DECRYPT": | ||
| commitmentPolicy = commitment.REQUIRE_ENCRYPT_ALLOW_DECRYPT | ||
| case "FORBID_ENCRYPT_ALLOW_DECRYPT": | ||
| commitmentPolicy = commitment.FORBID_ENCRYPT_ALLOW_DECRYPT |
Contributor
There was a problem hiding this comment.
Why not have the input.Config.CommitmentPolicy type as commitment.CommitmentPolicy ? Maybe because commitment.CommitmentPolicy doesn't have the json tag?
Author
There was a problem hiding this comment.
I think that'd be more effort -- this input is coming in from the Java test servers as a string, and I think I'd need to do some extra work to align these. But I think this is fine
ShubhamChaturvedi7
approved these changes
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
To simplify reading this, here's the diff between the v3/v4
main.goserver implementation: diff.txtBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.