add all-examples directory, Ruby V2 example#64
Merged
Conversation
…ption-client-python into kessplas/example-projs
| Each language has subdirectories for different major versions of the S3 Encryption Client: | ||
|
|
||
| - `cpp/` - C++ examples | ||
| - `v2/` - S3EC C++ v2 example |
There was a problem hiding this comment.
Should we specify that the older versions are "transition" and not current?
Comment on lines
+118
to
+124
| # Clean up the test object using regular S3 client | ||
| # s3_client.delete_object({ | ||
| # bucket: bucket_name, | ||
| # key: object_key | ||
| # }) | ||
|
|
||
| puts "✅ Test object deleted from S3" |
Comment on lines
+129
to
+138
| puts "📝 This example demonstrates the Amazon S3 Encryption Client v2 for Ruby" | ||
| puts "performing a complete roundtrip of encrypting data during upload and" | ||
| puts "decrypting it during download, using AWS KMS for key management." | ||
| puts | ||
| puts "Key features demonstrated:" | ||
| puts "• Client-side encryption using AES-GCM" | ||
| puts "• KMS integration for key wrapping" | ||
| puts "• Encryption context for additional security" | ||
| puts "• Automatic key rotation and management" | ||
| puts "• Secure roundtrip data integrity verification" |
| puts "✅ Successfully uploaded encrypted object to S3!" | ||
| puts " Bucket: #{bucket_name}" | ||
| puts " Key: #{object_key}" | ||
| puts " ETag: #{put_response.etag}" |
There was a problem hiding this comment.
Hum I don't know what this is or why it's important, could you add a comment
Comment on lines
+54
to
+56
| puts " Key Wrap Schema: kms_context" | ||
| puts " Content Encryption Schema: aes_gcm_no_padding" | ||
| puts " Security Profile: v2" |
There was a problem hiding this comment.
Not sure if should hardcode this print. Someone can update config and prints would be wrong
|
|
||
| puts "--- Step 2: Encrypt and Upload Object to S3 ---" | ||
|
|
||
| # Optional: Add encryption context for additional security |
There was a problem hiding this comment.
Do we just want to write "additional security"? I think better phrasings exist
lucasmcdonald3
previously approved these changes
Nov 6, 2025
| puts "--- Encrypt and Upload Object to S3 ---" | ||
|
|
||
| # Optional: Add encryption context for additional security | ||
| # Add encryption context for additional security |
There was a problem hiding this comment.
Still not a fan of the phrase "additional security" it leaves a bad taste in my mouth
Add v3 Ruby example Co-authored-by: Kess Plasmeier <76071473+kessplas@users.noreply.github.com>
lucasmcdonald3
approved these changes
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
n/a
Description of changes:
Add example projects for manual testing of each library major version. Starts with just Ruby V2.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.