chore: Go v4 example, run examples in CI#65
Merged
Conversation
…ption-client-python into kessplas/example-projs
lucasmcdonald3
changed the base branch from
fireegg-test-servers
to
kessplas/example-projs
lucasmcdonald3
changed the title
lucasmcdonald3
changed the title
added 2 commits
November 7, 2025 11:09
lucasmcdonald3
changed the title
ShubhamChaturvedi7
previously approved these changes
Nov 10, 2025
ShubhamChaturvedi7
left a comment
ShubhamChaturvedi7
left a comment
Contributor
There was a problem hiding this comment.
Some clarifications below, otherwise lgtm.
Comment on lines
+14
to
+28
| - name: Checkout code | ||
| uses: actions/checkout@v5 | ||
| with: | ||
| submodules: recursive | ||
| token: ${{ secrets.PAT_FOR_PRIVATE_RUBY }} | ||
|
|
||
| - name: Checkout CPP code for cpp-v2-transition | ||
| uses: actions/checkout@v5 | ||
| with: | ||
| submodules: recursive | ||
| token: ${{ secrets.PAT_FOR_CPP }} | ||
| repository: awslabs/aws-sdk-cpp-staging | ||
| ref: fire-egg-dev | ||
| path: test-server/cpp-v2-transition-server/aws-sdk-cpp/ | ||
|
|
Contributor
There was a problem hiding this comment.
Why special treatment for cpp and .net?
Author
There was a problem hiding this comment.
I just copy-pasted this from the test server CI, assuming there was good reason to do these
| run: pip install uv | ||
|
|
||
| # Cache Gradle dependencies and build outputs | ||
| - name: Cache Gradle packages |
Contributor
There was a problem hiding this comment.
Is there a reason why we cache and not install fresh gradle?
Author
There was a problem hiding this comment.
Not 100% sure, this is just from the test server CI
|
|
||
| ## Prerequisites | ||
|
|
||
| 1. **Go**: Requires Go 1.24 or later |
Contributor
There was a problem hiding this comment.
Our CI runs with go 1.25 though.
Author
There was a problem hiding this comment.
Oh good catch I'll downgrade CI version
Base automatically changed from
kessplas/example-projs
to
fireegg-test-servers
November 10, 2025 21:48
kessplas
dismissed
ShubhamChaturvedi7’s stale review
The base branch was changed.
Merged
added 2 commits
November 10, 2025 14:38
ShubhamChaturvedi7
approved these changes
Nov 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.