chore: fix instruction file tests for php#66
Merged
Conversation
josecorella
changed the title
kessplas
reviewed
Nov 7, 2025
Comment on lines
+53
to
+73
| if (!$instructionFileConfig) { | ||
| $result = $s3ec->putObject([ | ||
| '@SecurityProfile' => $legacy, | ||
| '@MaterialsProvider' => $materialProvider, | ||
| '@KmsEncryptionContext' => $encryptionContext, | ||
| '@CipherOptions' => $cipherOptions, | ||
| 'Bucket' => $bucket, | ||
| 'Key' => $key, | ||
| 'Body' => $rawBody, | ||
| ]); | ||
| } else { | ||
| $strategy = new InstructionFileMetadataStrategy($s3Client); | ||
| $result = $s3ec->putObject([ | ||
| '@SecurityProfile' => $legacy, | ||
| '@MaterialsProvider' => $materialProvider, | ||
| '@KmsEncryptionContext' => $encryptionContext, | ||
| '@MetadataStrategy' => $strategy, | ||
| '@CipherOptions' => $cipherOptions, | ||
| 'Bucket' => $bucket, | ||
| 'Key' => $key, | ||
| 'Body' => $rawBody, |
Contributor
There was a problem hiding this comment.
Style nit: can we refactor this to make it one putObject call, where '@MetadataStrategy' is conditionally set by !$instructionFileConfig? That would be more maintainable if possible.
Author
There was a problem hiding this comment.
maybe, I have to double check how the client deals with passing an empty MetadataStrategy
Contributor
There was a problem hiding this comment.
| 'Key' => $key, | ||
| 'Body' => $rawBody, | ||
| ]); | ||
| } else { |
kessplas
approved these changes
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.