chore: add S3EC .NET v2 and v3 test server#7
Conversation
…s3-encryption-client-python into rishav/dotnet/testserver
…v/dotnet/testserver
texastony
left a comment
There was a problem hiding this comment.
Going to try and call @rishav-karanjit today, I have a few questions.
Co-authored-by: Tony Knapp <5892063+texastony@users.noreply.github.com>
texastony
left a comment
There was a problem hiding this comment.
Requested Change: Make ClientRequest.cs appear exactly like the Smithy Model for the test service.
This should be a very small change.
|
Issue #, if available: Description of changes: Revising the call out
The above is NOT true; S3EC .NET v2 & v3 to send EC on encrypt, but they send the client's EC.
This is completely false. Testing ECThis PR does not test EC in the S3EC for .NET v2 & v3 at all. |
| var kmsKeyId = request.Config.KeyMaterial.KmsKeyId; | ||
| var enableLegacyUnauthenticatedModes = request.Config.EnableLegacyUnauthenticatedModes; | ||
| var enableLegacyWrappingAlgorithms = request.Config.EnableLegacyWrappingAlgorithms; | ||
| var encryptionContext = request.Config.EncryptionContext; |
There was a problem hiding this comment.
| var encryptionContext = request.Config.EncryptionContext; |
|
|
||
| public class ClientConfig | ||
| { | ||
| public Dictionary<string, string> EncryptionContext { get; set; } = new(); |
There was a problem hiding this comment.
| public Dictionary<string, string> EncryptionContext { get; set; } = new(); |
…s3/RoundTripTests.java
Issue #, if available:
Description of changes:
Adds dotnet test sever implementation.
Call out
.NET also does not have a way to send EC on encrypt/decrypt path but the tests are configured to send it only on encrypt/decrypt path. So, following tests are skipped:
crossLanguageTestKmsWithSubsetEncCtxFails on both encrypt and decrypt path of .NET:
crossLanguageTestKmsWithEncCtx on encrypt path of .NET:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.