Skip to content

chore: enable java-v3-transition test server#70

Merged
imabhichow merged 44 commits into
fireegg-test-serversfrom
imabhichow/java-test-server-v3
Nov 13, 2025
Merged

chore: enable java-v3-transition test server#70
imabhichow merged 44 commits into
fireegg-test-serversfrom
imabhichow/java-test-server-v3

Conversation

@imabhichow

@imabhichow imabhichow commented Nov 10, 2025

Copy link
Copy Markdown

Issue #, if available:

Description of changes:

  • Most of the difference is in white space; while reviewing, hide whitespace to review actual code changes.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Comment thread test-server/java-tests/src/it/java/software/amazon/encryption/s3/TestUtils.java Outdated

@rishav-karanjit rishav-karanjit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imabhichow imabhichow marked this pull request as ready for review November 10, 2025 19:21
Base automatically changed from imabhichow/java-v4-extended-tests to fireegg-test-servers November 10, 2025 19:23
@imabhichow imabhichow dismissed rishav-karanjit’s stale review November 10, 2025 19:23

The base branch was changed.

Comment thread .gitmodules Outdated
url = git@github.com:aws/private-amazon-s3-encryption-client-java-staging.git
branch = imabhichow/add-kc
; branch = s3ec/improved
[submodule "test-server/java-v4-server/specification"]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the plan is to fix thing right?

@rishav-karanjit rishav-karanjit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imabhichow imabhichow merged commit a4dc46f into fireegg-test-servers Nov 13, 2025
4 checks passed
@imabhichow imabhichow deleted the imabhichow/java-test-server-v3 branch November 13, 2025 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants