Skip to content

chore: update php to use iv of 1s #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ajewellamz merged 3 commits into from
Nov 13, 2025
Merged

chore: update php to use iv of 1s #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef4acb0
chore: update php to use iv of 1s
josecorella Nov 13, 2025
00b876c
chore: enable php testing
josecorella Nov 13, 2025
f0c95fe
fix up php dirs
josecorella Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,27 +156,27 @@ jobs:
aws-region: us-west-2

- name: Build the servers
run: cd test-server && make build-all-servers FILTER=ruby,go,cpp
run: cd test-server && make build-all-servers FILTER=ruby,go,cpp,php
env:
MAKEFLAGS: -j${{ steps.cpu-count.outputs.count }}
AWS_REGION: us-west-2

- name: Start the servers
run: cd test-server && make start-all-servers FILTER=ruby,go,cpp
run: cd test-server && make start-all-servers FILTER=ruby,go,cpp,php
env:
AWS_REGION: us-west-2
TEST_SERVER_S3_BUCKET: ${{ vars.TEST_SERVER_S3_BUCKET }}
TEST_SERVER_KMS_KEY_ARN: ${{ vars.TEST_SERVER_KMS_KEY_ARN }}

- name: Wait for servers to start
run: cd test-server && make wait-all-servers FILTER=ruby,go,cpp
run: cd test-server && make wait-all-servers FILTER=ruby,go,cpp,php
env:
AWS_REGION: us-west-2
TEST_SERVER_S3_BUCKET: ${{ vars.TEST_SERVER_S3_BUCKET }}
TEST_SERVER_KMS_KEY_ARN: ${{ vars.TEST_SERVER_KMS_KEY_ARN }}

- name: Run run-tests
run: cd test-server && make run-tests FILTER=ruby,go,cpp
run: cd test-server && make run-tests FILTER=ruby,go,cpp,php
env:
AWS_REGION: us-west-2
TEST_SERVER_S3_BUCKET: ${{ vars.TEST_SERVER_S3_BUCKET }}
Expand All @@ -194,7 +194,7 @@ jobs:
test-server/*/net-v3-server.log

- name: Stop the servers
run: cd test-server && make stop-servers FILTER=ruby,go,cpp
run: cd test-server && make stop-servers FILTER=ruby,go,cpp,php

- name: Upload results
if: always()
Expand Down
4 changes: 0 additions & 4 deletions .gitmodules
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,6 @@
path = test-server/specification
url = git@github.com:awslabs/private-aws-encryption-sdk-specification-staging.git
branch = fire-egg-staging
[submodule "test-server/php-v2-transition-server/local-php-sdk"]
path = test-server/php-v2-transition-server/local-php-sdk
url = git@github.com:aws/private-aws-sdk-php-staging.git
branch = s3ec/transitional
[submodule "test-server/net-v2-v3-server/s3ec-net-v2"]
path = test-server/net-v2-v3-server/s3ec-net-v2
url = https://github.com/aws/private-amazon-s3-encryption-client-dotnet-staging.git
Expand Down
1 change: 0 additions & 1 deletion test-server/php-v2-transition-server/local-php-sdk
Open in desktop
Submodule local-php-sdk deleted from 8e2210
1 change: 1 addition & 0 deletions test-server/php-v2-transition-server/local-php-sdk
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
../php-v3-server/local-php-sdk
1 change: 0 additions & 1 deletion test-server/php-v2-transition-server/local-php-sdk~fireegg-test-servers
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion test-server/php-v3-server/local-php-sdk
Open in desktop
Submodule local-php-sdk updated from 8e2210 to c81d43
Loading