feat(s3files): alpha package for L2 Constructs - #38435
Open
Adonca2203 wants to merge 1 commit into
Open
Conversation
aws-cdk-automation
previously requested changes
Jul 28, 2026
aws-cdk-automation
dismissed
their stale review
July 28, 2026 18:15
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
temporarily deployed
to
automation
July 28, 2026 18:38 — with
GitHub Actions
Inactive
aws-cdk-automation
temporarily deployed
to
automation
July 28, 2026 18:38 — with
GitHub Actions
Inactive
Adonca2203
force-pushed
the
adonca2203/s3files-alpha-l2
branch
from
July 28, 2026 19:11
1faf21b to
512d5c7
Compare
Adonca2203
force-pushed
the
adonca2203/s3files-alpha-l2
branch
from
July 28, 2026 20:05
512d5c7 to
89146f7
Compare
Adonca2203
force-pushed
the
adonca2203/s3files-alpha-l2
branch
from
July 29, 2026 14:29
89146f7 to
155d8b9
Compare
Adonca2203
force-pushed
the
adonca2203/s3files-alpha-l2
branch
from
July 29, 2026 14:54
155d8b9 to
c01302c
Compare
Adonca2203
force-pushed
the
adonca2203/s3files-alpha-l2
branch
from
July 29, 2026 15:58
c01302c to
c091863
Compare
Adonca2203
force-pushed
the
adonca2203/s3files-alpha-l2
branch
from
July 29, 2026 21:23
c091863 to
bdd2ed8
Compare
Adonca2203
force-pushed
the
adonca2203/s3files-alpha-l2
branch
from
July 31, 2026 15:08
bdd2ed8 to
3c5c31d
Compare
aws-cdk-automation
previously requested changes
Aug 4, 2026
Add @aws-cdk/aws-s3files-alpha package with FileSystem and AccessPoint L2 constructs. Includes VPC mount target management, IAM role automation, grants facade, resource policies, and integration tests.
Adonca2203
force-pushed
the
adonca2203/s3files-alpha-l2
branch
from
August 4, 2026 17:38
4bec28d to
ee84592
Compare
aws-cdk-automation
dismissed
their stale review
August 4, 2026 17:40
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
temporarily deployed
to
automation
August 4, 2026 18:36 — with
GitHub Actions
Inactive
aws-cdk-automation
temporarily deployed
to
automation
August 4, 2026 18:36 — with
GitHub Actions
Inactive
leonmk-aws
requested changes
Aug 7, 2026
| * Number of days after last access before cached data expires. | ||
| * Must be a whole number of days between 1 and 365. | ||
| */ | ||
| readonly daysAfterLastAccess: Duration; |
Contributor
There was a problem hiding this comment.
According to the RFC should be dataExpiration any reason to change it ?
| importDataRules: config.importDataRules.map(rule => ({ | ||
| prefix: rule.prefix, | ||
| sizeLessThan: rule.sizeLessThan.toBytes(), | ||
| trigger: rule.trigger ?? ImportDataRuleTrigger.ON_FILE_ACCESS, |
Contributor
There was a problem hiding this comment.
Line 100 says that the default is ON_DIRECTORY_FIRST_ACCESS
leonmk-aws
requested changes
Aug 7, 2026
|
|
||
| const basicStack = new BasicFileSystemStack(app, 'S3FilesBasicStack'); | ||
| const syncConfigStack = new FileSystemWithSyncConfigStack(app, 'S3FilesSyncConfigStack'); | ||
| const accessPointStack = new FileSystemWithAccessPointStack(app, 'S3FilesAccessPointStack'); |
Contributor
There was a problem hiding this comment.
Can we split this in 3 integ tests, this allows for faster deployment and more clarity
aws-cdk-automation
temporarily deployed
to
automation
August 7, 2026 17:05 — with
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #37568.
Reason for this change
Introduces L2 constructs for AWS S3Files abstracting L1 constructs behind easier to digest and sensible defaults.
Description of changes
Introduced new package
@aws-cdk/aws-s3files-alphawhich adds L2 Constructs for:AccessPoint: Represents an application-specific view into a file systemFileSystem: Represents the S3Files file systemMountTarget: Represents a mount point for the file systemAlongside unit and integration tests
Describe any new or updated permissions being added
The L2 Constructs create a default role for S3Files if one is not provided. This role is required for S3Files to work properly and is used to grant the file system layer access to the customer's S3 Bucket prefixes, kms keys, and event bridge rules.
Description of how you validated changes
Ran the provided integration tests
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license