Skip to content

feat(apigateway): dualstack custom domain REST API - #38477

Open
pedropedruzzi wants to merge 6 commits into
aws:mainfrom
pedropedruzzi:dualstack-apigateway-custom-domain-name
Open

feat(apigateway): dualstack custom domain REST API#38477
pedropedruzzi wants to merge 6 commits into
aws:mainfrom
pedropedruzzi:dualstack-apigateway-custom-domain-name

Conversation

@pedropedruzzi

@pedropedruzzi pedropedruzzi commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Issues

Resolves the missing domain name part of #33998. Note: the part for default REST API endpoints was done in PR #34114.

Reason for this change

Allow enabling dualstack on REST API custom domain endpoints.

Description of changes

  • Defined a new EndpointConfiguration exclusive for DomainName, instead of using the existing interface of the RestApi class.
  • Since there is already the endpointType prop in the domain name level, I decided to omit the types from EndpointConfiguration to avoid having two ways to set the same thing.
  • I've considered the alternative design of having endpointIpAddressType directly in domain name (without endpoint configuration level). This is even cleaner but I thought it makes more sense to keep things in the same overall structure as API/CFN (e.g. to better cope with future field additions on the endpoint configuration). Let me know if you think this design is superior.

Describe any new or updated permissions being added

None.

Description of how you validated changes

Added unit and integration test cases. I hope to see integration tests run in CI.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions Bot added p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Aug 2, 2026
@aws-cdk-automation
aws-cdk-automation requested a review from a team August 2, 2026 21:02
@github-actions

github-actions Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

⚠️ The following issue reference(s) in your PR description are not valid issues:

Please make sure your PR references an existing issue using the format Closes #123.

@aws-cdk-automation aws-cdk-automation left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@aws-cdk-automation
aws-cdk-automation dismissed their stale review August 3, 2026 01:47

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants