Add warning for outdated SessionManagerPlugin version - #10520
Conversation
jonathan343
left a comment
jonathan343
left a comment
There was a problem hiding this comment.
Hey @rongjina987, overall these changes seem fine. Have two pretty minor suggestions.
| else: | ||
| return False | ||
|
|
||
| def meets_or_exceeds(self, version): |
There was a problem hiding this comment.
This function seems to implement identical behavior to meets_requirements, but is inclusive. Can we just update meets_requirements to accept an inclusive parameter that defaults to false: meets_requirement(version, inclusive=False). Then you could just do:
...
if inclusive:
return norm_version >= norm_min_version
return norm_version > norm_min_version| 'WARNING: An outdated SessionManagerPlugin version detected. Please upgrade it to the latest version. \n' | ||
| 'For more information, refer:\n' |
There was a problem hiding this comment.
super nit - split this string into two lines for readability. The string value is unaffected
| 'WARNING: An outdated SessionManagerPlugin version detected. Please upgrade it to the latest version. \n' | |
| 'For more information, refer:\n' | |
| 'WARNING: An outdated SessionManagerPlugin version detected. ' | |
| 'Please upgrade it to the latest version. \n' | |
| 'For more information, refer:\n' |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #10520 +/- ##
===========================================
+ Coverage 93.42% 93.64% +0.22%
===========================================
Files 211 212 +1
Lines 17312 17383 +71
===========================================
+ Hits 16174 16279 +105
+ Misses 1138 1104 -34 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
3 participants
Issue #, if available:
There is the no warning message on terminal for outdated SessionManagerPlugin version, making slow adoption rate of new SessionManagerPlugin release
Description of changes:
Display warning message on terminal when SessionManagerPlugin version is outdated. Define version
1.2.764.0as the minimum suggested plugin versionTesting:
Warning message on outdated plugin version
Clean terminal on satisfied plugin version
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.