ci: continuously roll over long-running OTel tests - #59
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Addressed all three findings in
Added focused regressions for partial/terminal premature failures, transient polling reads, refreshed validation time, and all three workflow contracts. Full validation: 320 tests passed, plus typing, YAML lint, Ruff, formatting, and diff checks. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Addressed the in-flight compatibility issue in When a checked-out legacy source writes a result without
This lets legacy terminal successes and failures roll over while keeping partial-premature failures blocked. Added an executable missing-field regression covering legacy success, all-terminal failure, and partial failure. Validation on the rebased PR head: 325 tests passed, plus typing, YAML lint, Ruff, formatting, and diff checks. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Addressed both findings in e2a1299.
Added regressions for premature failure plus a pending callback and for legacy failed-result migration. Full local validation: 325 tests passed, plus types, YAML lint, Ruff, formatting, and |
Codex AI reviewNo actionable findings. Residual risk remains around live AWS callback polling and GitHub Actions artifact/output handoff, which unit tests cannot fully exercise. Reviewed commit |
Claude AI reviewReviewed the full diff against the base revision — the No actionable findings. I traced each branch and could not confirm any correctness, typing, error-handling, or schema-compatibility defect:
Residual test risk (not defects):
Reviewed commit |
Summary
rollover_readyby deriving readiness from all saved execution historiesTesting
hatch run test:all(325 passed)hatch run types:checkhatch run yaml:lint .github/workflowshatch check codehatch check fmtgit diff --check