Add hook-info field-shape conformance handlers - #602
Draft
wangyb-A wants to merge 2 commits into
Draft
Conversation
wangyb-A
requested a deployment
to
ai-pr-review-runtime
August 6, 2026 23:55 — with
GitHub Actions
Waiting
wangyb-A
requested a deployment
to
ai-pr-review-runtime
August 6, 2026 23:55 — with
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds 4 conformance handlers (
conformance-tests/src/main/java/plugin/Plugin{InvocationInfo,OperationInfo,AttemptInfo,OperationChange}Shape.java) +template_plugin.yamlentries implementing plugin hook-info FIELD-SHAPE requirements 10-19..10-22 from aws/aws-durable-execution-conformance-tests#72 (land that PR first).Each handler logs ONE single-line JSON record per hook event: a CANONICAL camelCase DUMP of that hook's own info record — every component the record type exposes is mapped one-to-one to the canonical name (timestamps
Instant.toString(),succeeded→outcometoken, error message strings; map fields as<name>Countintegers; null/unexposed fields OMITTED — a missing key fails its assertion, which is the parity signal). Real SDK APIs only; spotless-clean.Live validation (us-west-2): 17/20 — THREE DELIBERATE FAILURES (SDK parity gaps, kept failing by design)
InvocationInfo(requestId, durableExecutionArn, isFirstInvocation, executionStartTime)has no execution input and no operations/updated-operations maps;InvocationEndInfohas no execution result. (Its end-infoisFirstInvocationand the start timestamp PASS — ahead of JS on the former.)OperationEndInfoexposes no serialized-result accessor (same root gap as the 10-14 red test / #581).OperationChangeItemInfolacks result, attempt, and a replay indicator — JS/Python change items are full operation infos.Suggested fixes: converge on one shared operation-info field set (status/result/error/attempt/isReplay) across
OperationInfo/OperationEndInfo/OperationChangeItemInfo, and enrich the invocation infos with execution input, the operations/updated-operations maps, and the execution result to matchInvocationBaseInfo/InvocationEndInfoin JS.