fix(otel): close spans child first at invocation end - #603
Draft
zhongkechen wants to merge 1 commit into
Draft
Conversation
zhongkechen
requested a deployment
to
ai-pr-review-runtime
August 7, 2026 02:57 — with
GitHub Actions
Waiting
zhongkechen
requested a deployment
to
ai-pr-review-runtime
August 7, 2026 02:57 — with
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
InvocationOtelPlugin.onInvocationEnd()previously ended open operation spans by iterating aConcurrentHashMap. Its iteration order is unspecified, so a parent operation could be ended before a still-open child. This produced child end timestamps a few microseconds later than the parent and failed OTel conformance validation.The plugin now keeps keyed span access in the concurrent map and records start order in a
ConcurrentLinkedDeque. Invocation shutdown closes attempts first, then polls operation IDs from the deque tail so descendants close before ancestors. IDs for operations already completed are skipped when their span is absent from the map.Impact
Interrupted invocations now export properly nested span timestamps while preserving concurrent keyed access for normal operation lifecycle events.
Validation
mvn -pl otel-plugin spotless:applymvn -pl otel-plugin test(123 tests passed)