-
Notifications
You must be signed in to change notification settings - Fork 22
feat(otel): fully enum-driven OtelPluginConfig #612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
4e5fe40
feat(otel): InvocationOtelPlugin uses config
hsilan 1b0e6e0
fix(otel): example handlers use global provider
hsilan b70c4f9
refactor(otel): resolve provider source via enum
hsilan 4bd4a75
refactor(otel): move ProviderSource enum into config
hsilan 8fc3614
refactor(otel): make config fully provider_source-driven
hsilan 327b360
style(otel): apply ruff format
hsilan 665fcca
refactor(otel): default provider_source to GLOBAL
hsilan b942a5e
refactor(otel): make AUTO_OTLP branch explicit
hsilan e99fb51
Merge branch 'main' into feat/otel-invocation-config
SilanHe c8b0620
ci: re-trigger ci
hsilan f77a6c5
docs(otel): correct provider_source default in comments
hsilan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These new doc comments are stale and contradict the API this PR ships:
use_default_tracer_provider, which this PR removes fromOtelPluginConfig. Passing it now raisesTypeError(unknown field). The same dead reference appears again in the API-reference block below (line 264:# ...and the rest of OtelPluginConfig (use_default_tracer_provider, ...)).provider_source=GLOBAL(usestrace.get_tracer_provider()), notAUTO_OTLP. Auto-configuration now requiresprovider_source=ProviderSource.AUTO_OTLP.tracer_provider=Noneexample with the comment "Provide your own TracerProvider if you already have one configured" is misleading — supplying a provider now requiresprovider_source=ProviderSource.EXPLICIT, otherwiseOtelPluginConfig.__post_init__raisesValueError.Suggest rewording these comments to describe
provider_source(GLOBAL default; AUTO_OTLP to build/own an OTLP provider; EXPLICIT +tracer_providerto supply your own) and dropping theuse_default_tracer_providermentions here and at line 264.