Skip to content

Add credentials_file_path configuration parameter for file-based credential support#176

Closed
reyhankoyun wants to merge 4 commits intomainfrom
file-based-creds-config
Closed

Add credentials_file_path configuration parameter for file-based credential support#176
reyhankoyun wants to merge 4 commits intomainfrom
file-based-creds-config

Conversation

@reyhankoyun
Copy link
Copy Markdown
Contributor

PR 1/3 for file-based credential support.

Adds an optional credentials_file_path configuration parameter and the default credentials file path constant. No runtime behavior change, the field is parsed and stored but not yet consumed.

@reyhankoyun reyhankoyun requested a review from a team as a code owner March 19, 2026 01:11
@reyhankoyun reyhankoyun added the safe-to-test Maintainer approval to run integration tests for external contributor PRs. label Mar 19, 2026
@github-actions github-actions bot removed the safe-to-test Maintainer approval to run integration tests for external contributor PRs. label Mar 19, 2026
@codecov

This comment was marked as outdated.

@reyhankoyun reyhankoyun added the safe-to-test Maintainer approval to run integration tests for external contributor PRs. label Mar 19, 2026
@github-actions github-actions bot removed the safe-to-test Maintainer approval to run integration tests for external contributor PRs. label Mar 19, 2026
@reyhankoyun reyhankoyun force-pushed the file-based-creds-config branch from eba2d73 to 7e2a81f Compare March 23, 2026 17:58
@reyhankoyun reyhankoyun added the safe-to-test Maintainer approval to run integration tests for external contributor PRs. label Mar 23, 2026
@github-actions github-actions bot removed the safe-to-test Maintainer approval to run integration tests for external contributor PRs. label Mar 23, 2026
@reyhankoyun
Copy link
Copy Markdown
Contributor Author

The 2 partial coverage lines are ? error branches on set_default() calls, identical to every other set_default line in the same function, which also have uncovered error branches. No way to exercise these without mocking the config library internals.

@reyhankoyun reyhankoyun force-pushed the file-based-creds-config branch from 7e2a81f to c7a0534 Compare March 23, 2026 19:02
@reyhankoyun reyhankoyun force-pushed the file-based-creds-config branch from c7a0534 to e4d4a01 Compare March 23, 2026 19:04
@reyhankoyun reyhankoyun added the safe-to-test Maintainer approval to run integration tests for external contributor PRs. label Mar 23, 2026
@github-actions github-actions bot removed the safe-to-test Maintainer approval to run integration tests for external contributor PRs. label Mar 23, 2026
@simonmarty
Copy link
Copy Markdown
Contributor

Should we add a negative test case (tries to pass malformed pass to the config, fails, expect a specific error)?

@reyhankoyun
Copy link
Copy Markdown
Contributor Author

Should we add a negative test case (tries to pass malformed pass to the config, fails, expect a specific error)?

Maybe not for this PR. The credentials_file_path field is Option<PathBuf>, any string is a valid PathBuf, so there's no malformed value that would fail at the config parsing stage. A path like /tmp/nonexistent is a valid PathBuf; it just doesn't point to an existing file, which will be handled at runtime in a follow up PR.

@reyhankoyun reyhankoyun added the safe-to-test Maintainer approval to run integration tests for external contributor PRs. label Mar 23, 2026
@github-actions github-actions bot removed the safe-to-test Maintainer approval to run integration tests for external contributor PRs. label Mar 23, 2026
@reyhankoyun reyhankoyun added the safe-to-test Maintainer approval to run integration tests for external contributor PRs. label Mar 24, 2026
@github-actions github-actions bot removed the safe-to-test Maintainer approval to run integration tests for external contributor PRs. label Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants