Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #178 +/- ##
=======================================
Coverage 92.14% 92.14%
=======================================
Files 14 14
Lines 2405 2405
Branches 2405 2405
=======================================
Hits 2216 2216
Misses 143 143
Partials 46 46 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| "hex", | ||
| "http 1.4.0", | ||
| "ring", | ||
| "sha1", |
There was a problem hiding this comment.
why move from ring to sha1?
| "bytes", | ||
| "fastrand", | ||
| "http 0.2.12", | ||
| "http 1.4.0", |
There was a problem hiding this comment.
Do we need both http versions here? If we support both now, what will be our migration strategy to only using Major version 1?
Same for multiple other places.
| ] | ||
|
|
||
| [[package]] | ||
| name = "sha1" |
There was a problem hiding this comment.
The SHA-1 hash function should be considered cryptographically broken and unsuitable for further use in any security critical capacity, as it is practically vulnerable to chosen-prefix collisions.
Description
Why is this change being made?
What is changing?
Related Links
Testing
How was this tested?
cargo test --exclude integration_tests --workspaceWhen testing locally, provide testing artifact(s):
Reviewee Checklist
Update the checklist after submitting the PR
If not, why:
If not, why:
If not, why:
If not, why:
If not, why: Did not run integ tests locally, will wait for GH action run.
If not, why: Not needed since this is just a dependency version update.
If not, why: Not applicable, we are just doing dependency update.
If not, why: No complex logic added.
If not, why: No changes to readme needed for a version update.
If not, why: No breaking changes.
Reviewer Checklist
All reviewers please ensure the following are true before reviewing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.