Skip to content

Add DescribeSecret cache #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
simonmarty wants to merge 3 commits into
base: main
Choose a base branch
from

Merge branch 'main' into cache_describe

5f1a161
Select commit
Loading
Failed to load commit list.
Draft

Add DescribeSecret cache #22

Merge branch 'main' into cache_describe
5f1a161
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Dec 16, 2025 in 1s

66.59% (-2.44%) compared to 994fe63

View this Pull Request on Codecov

66.59% (-2.44%) compared to 994fe63

Details

Codecov Report

❌ Patch coverage is 23.97661% with 130 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.59%. Comparing base (994fe63) to head (5f1a161).
⚠️ Report is 47 commits behind head on main.

Files with missing lines Patch % Lines
...nager_caching/src/output/describe_secret_output.rs 0.00% 89 Missing ⚠️
...nager_caching/src/secret_store/memory_store/mod.rs 4.54% 21 Missing ⚠️
aws_secretsmanager_caching/src/lib.rs 60.78% 20 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
- Coverage   69.03%   66.59%   -2.44%     
==========================================
  Files          13       14       +1     
  Lines        2842     2967     +125     
  Branches       10        9       -1     
==========================================
+ Hits         1962     1976      +14     
- Misses        880      991     +111

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov