Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
=======================================
Coverage 91.72% 91.72%
=======================================
Files 14 14
Lines 2418 2418
Branches 2418 2418
=======================================
Hits 2218 2218
Misses 150 150
Partials 50 50 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Simon Marty <martysi@amazon.com>
de875e6 to
cde666a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: See #9
https://doc.rust-lang.org/cargo/reference/profiles.html
Description of changes:
Experimenting with release profile parameters
lto = "thinto use link time optimization across the dependency tree. This increases the binary size by 0.5MB onstable-x86_64-apple-darwin. At the moment I'm not seeing a significant performance disparity between this being set to "thin" or "off". This might differ between platforms.codegen-units = 1, significantly increases compilation time, is supposed to help with optimization, does appear to reduce binary size by a little over 1MB.strip = trueRemoves symbols and debug info, reduces binary size (13MB -> 9MB).Before merging:
Run a load test and verify this leads to a consistent performance improvement on
stable-x86_64-unknown-linux-gnustable-x86_64-unknown-linux-muslstable-aarch64-unknown-linux-gnustable-aarch64-unknown-linux-muslstable-x86_64-pc-windows-msvcBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.