Conversation
Restructure strands integration by moving converters into a dedicated `converters/` subpackage. Rename `AgentCoreMemoryConverter` to `BedrockConverseConverter`, add `OpenAIConverseConverter` for OpenAI format support, and introduce a `MemoryConverter` protocol to define a common interface. Update `StrandsMemoryHook` to accept any converter implementing the protocol, defaulting to `BedrockConverseConverter`.
- Carry over `status` field from Bedrock toolResult when converting to OpenAI format, and restore it when converting back to Bedrock format - Refactor _openai_to_bedrock tool response construction for clarity - Change fallback content from None to empty string for non-tool messages - Add round-trip test assertion for status preservation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#254
Description of changes:
OpenAI-format payloads in STM events. Handles text messages, tool calls (tool_calls), tool results (tool role), and system messages with bidirectional
conversion.
and OpenAIConverseConverter implement. Shared logic (exceeds_conversational_limit, CONVERSATIONAL_MAX_SIZE) is centralized in protocol.py.
in OpenAIConverseConverter or any custom implementation that satisfies the MemoryConverter protocol.
handling. Add 143 lines of tests for the injectable converter integration on the session manager (default/custom converter, blob fallback, empty payloads).
Test plan
TestInjectableConverter class
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.