Skip to content

Fix resolve syntax error in parsing EKS_ANYWHERE_TARBALL_URL#9215

Open
James-Lu-none wants to merge 2 commits intoaws:mainfrom
James-Lu-none:eksctl-anywhere-plugin-install-script
Open

Fix resolve syntax error in parsing EKS_ANYWHERE_TARBALL_URL#9215
James-Lu-none wants to merge 2 commits intoaws:mainfrom
James-Lu-none:eksctl-anywhere-plugin-install-script

Conversation

@James-Lu-none
Copy link
Copy Markdown

Description of changes:

  1. remove quote escaping for RELEASE_VRESION (causing duplicated quote)
  2. resolve OS name before parsing tarball url (since yq wont resolve $(uname -s | tr A-Z a-z))

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chrisnegus for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot
Copy link
Copy Markdown
Collaborator

Hi @James-Lu-none. Thanks for your PR.

I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot eks-distro-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/docs Documentation documentation needs-ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants